-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
npm postinstall uses global bower that might not exist #224
Comments
Thanks for the info, I don't know a great deal how NPM but is there a way to specify local npm during runtime? You also have the option of pre-compiling the javascript. The installation script is smart enough to check for the static/dist folder and not try to re-compile it if it exists. This is actually how we deploy it, jenkins builds a deb with compiled javascript inside. |
Probably the cleanest way to use the local bower it to change the postinstall line to this:
As a thought exercise, do you have an example of how to pre-compile the javascript that I could use before |
Mind opening up a PR with that change? It looks good to me. This is essentially what I do in jenkins:
|
Closing based on #227. |
While trying to dockerize lemur for running in our environment, I ran into an issue that I thought I'd document in case anyone else encounters it.
Following the installation instructions, you start up the python virtual environment and
make develop
. This takes a while in a docker container, but eventually will error out with this:I traced this to the fact that
bower install
fails to run during the setup phase, because package.json has this line:npm will use the global bower after installing the node modules and will fail (very quietly) if one doesn't exist:
The way to workaround this error is to run bower install after the failure, using the local bower. I used something like this:
If package.json is changed so the postinstall command uses the bower installation within the node_modules directory, this workaround won't be needed. Not sure if this should truly be a bug or if it's just a documentation clarification - I'll let the maintainers decide.
The text was updated successfully, but these errors were encountered: