Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canceling previous requests in dropdowns #889

Open
jamesplease opened this issue Aug 28, 2017 · 0 comments
Open

Canceling previous requests in dropdowns #889

jamesplease opened this issue Aug 28, 2017 · 0 comments

Comments

@jamesplease
Copy link
Member

👋

Type: Bug

Description: Dropdown searches (such as for Notifications) are not canceled when a new search is entered. This can cause incorrect search results to be displayed in certain situations.

More info:

When a user types into a dropdown, slow backends can lead to multiple concurrent requests. Here is a screenshot showing this (these network requests are from searching for Notifications within the internal Netflix Lemur)

image

I'd expect to see something more like this:

image

This is a problem becomes requests may not resolve in the order that they were sent off. In the first screenshot above, the third request will return the results that the user is interested in. And although it was sent after the first two requests, there's no guarantee that it will return last.

To provide a specific example, consider a user searching for "Apples." They type it, and the request begins. They change their mind, and search for "Oranges." If the apples search isn't canceled, then it could be returned after the search for oranges.

Unless the UI app does some sophisticated tracking of requests, then the incorrect results will be displayed.

Suggested fix:

Aborting previous requests when a new request is initiated.

Thanks for reading!


(Note: I use the internal Netflix Lemur, and I'm not too familiar with this project, so I'm not sure if the Notifications dropdown is Netflix-specific)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant