Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project code Formatting #323

Closed
talebzeghmi opened this issue Sep 4, 2020 · 3 comments · Fixed by #771 or #772
Closed

Project code Formatting #323

talebzeghmi opened this issue Sep 4, 2020 · 3 comments · Fixed by #771 or #772

Comments

@talebzeghmi
Copy link

Goal: Consistent Metaflow project code.

Creating an issue to introduce Metaflow project code formatting and verification as part of the CICD process.

Ensuring that the whole code base, including plugins, follow the same style makes it easier to read and easier to write plugins in a consistent style.

suggest: https://github.com/psf/black

@savingoyal
Copy link
Collaborator

Thanks for opening the issue. There is a related issue #218 for checking code styles. It's something that we plan to get to soon.

@talebzeghmi
Copy link
Author

Awesome, let me know if I can help!
This task is for formatting and updating the Metaflow core code style (example: https://github.com/Netflix/metaflow/blob/master/metaflow/cli.py)

@savingoyal
Copy link
Collaborator

@talebzeghmi #771 lints the entire codebase with black.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants