Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tc-bytecode in 2019-001 may erroneously match values in tcp timestamp options? #3

Open
kcid9660 opened this issue Jun 17, 2019 · 1 comment

Comments

@kcid9660
Copy link

I don't think there's anything to ensure it is not evaluating any four bytes of timestamp's eight bytes of values. Re-transmitted segments with newer TS values are less likely to also be matched erroneously (except for maybe echo values on SYN|ACKs) but the session might have to pay the initial rto penalty.

@mcbrutus
Copy link

Agreed, the bpf code does a simple tcp option parse at all possible offsets of they option space so a syn could be dropped in error and the client would have to pay a rto penalty.

An update is possible to skip timestamp options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants