Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System.getProperties() in DefaultMonitorRegistry.java #443

Closed
ravikancherla opened this issue Mar 28, 2018 · 3 comments
Closed

System.getProperties() in DefaultMonitorRegistry.java #443

ravikancherla opened this issue Mar 28, 2018 · 3 comments

Comments

@ravikancherla
Copy link
Contributor

ravikancherla commented Mar 28, 2018

Hi,

I am trying to implement Eureka client to my application and I don't have access to get all the system properties (java.util.PropertyPermission, "*", "read,write").

When creating instance for DefaultMonitorRegistry, it is calling System.getProperties(). Can you please change it so that it can access properties individually ? That way, i can ask our server administrators to add the permission by each property but they won't be ready to give read and write to everything

I am not using Servo anyway. If there is a way to disable Servo, that works for me too

Caused by: java.security.AccessControlException: access denied ("java.util.PropertyPermission" "*" "read,write")
                at java.security.AccessControlContext.checkPermission(AccessControlContext.java:472)
                at java.security.AccessController.checkPermission(AccessController.java:884)
                at java.lang.SecurityManager.checkPermission(SecurityManager.java:549)
                at java.lang.SecurityManager.checkPropertiesAccess(SecurityManager.java:1262)
                at java.lang.System.getProperties(System.java:630)
                at com.netflix.servo.DefaultMonitorRegistry.<init>(DefaultMonitorRegistry.java:65)
                at com.netflix.servo.DefaultMonitorRegistry.<clinit>(DefaultMonitorRegistry.java:49)
                ... 65 common frames omitted
@brharrington
Copy link
Contributor

Not sure when I'll have time to look at it, but if you want to submit a PR we're happy to consider it.

@ravikancherla
Copy link
Contributor Author

#444

@brharrington
Copy link
Contributor

This change is in 0.12.21.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants