Subscription inventory accounting enhancements

[DavidePrincipi]

The inventory data is lacking some information.

Proposed solution

• Fix Mattermost active users counter. It seems a recent update introduced a change of output format for mmctl --local --json user list. The is_bot attribute is not present, if value is false.
• Count Samba instances when acting as file servers fix: translating products lists ns8-user-manager#24
• Merge get-facts output from all module instances to allow extensible metrics (required by NethVoice)
• NethVoice PR actions: add get-facts action nethesis/ns8-nethvoice#140
• Check the remote IP probe is a real IP string representation

Additional context

Discussion https://mattermost.nethesis.it/nethesis/pl/tpqnky7teirrdm7gn6dyozpsue

[DavidePrincipi]

Mattermost released
https://github.com/NethServer/ns8-mattermost/releases/tag/2.0.4

[DavidePrincipi]

⚠️ Samba is not returned by list-modules action here https://github.com/NethServer/ns8-samba/blob/613cdb432311b67e1c5b6e28be3049544654e07e/imageroot/bin/write-user-portal-config#L32

The user portal cannot list "Samba" among "connected services"

@Tbaile can we add hardcoded strings to names_set? Can we translate those strings in the User portal? 🙏

Something like:

• Windows authentication / Autenticazione Windows
• Network shared folders / Cartelle di rete condivise

[Tbaile]

Can do, adding support in NethServer/ns8-user-manager#24, need a list of what we need to translate tho, you can commit directly to the PR

[DavidePrincipi]

• samba 2.2.2-dev.1
• core 2.5.3-dev.7
• mattermost 2.0.4

Test case

• Mattermost count of active users has been fixed
• When Samba DC is File server, User portal displays "Windows authentication" and "Network shared folders" in the services list. Its active user counter is sent within Subscription inventory data

[DavidePrincipi]

[1 of 2] The User Portal is updated as expected

[DavidePrincipi]

VERIFIED

[DavidePrincipi]

Released in

• https://github.com/NethServer/ns8-core/releases/tag/2.5.3
• https://github.com/NethServer/mattermost/releases/tag/2.0.4
• https://github.com/NethServer/ns8-samba/releases/tag/2.2.2