Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve validation of host/domain set name #416

Merged
merged 2 commits into from
Oct 31, 2024
Merged

fix: improve validation of host/domain set name #416

merged 2 commits into from
Oct 31, 2024

Conversation

andre8244
Copy link
Collaborator

@andre8244 andre8244 commented Oct 30, 2024

Improve validation of domain sets and host sets:

  • Create/edit domain set: ensure domain names contained in the domain set are syntactically valid
  • Create/edit domain set: ensure that the total characters length of all domain names doesn't exceed 1024
  • Create/edit domain set or host set: ensure host set / domain set name starts with a letter and contains only letters and numbers

Ref:

@andre8244 andre8244 requested a review from Tbaile October 30, 2024 15:15
@andre8244 andre8244 merged commit 4dbfde5 into main Oct 31, 2024
3 checks passed
@andre8244 andre8244 deleted the issue-876 branch October 31, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants