Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mwan): fixing validation on default rule #431

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

Tbaile
Copy link
Collaborator

@Tbaile Tbaile commented Nov 11, 2024

Fixing issue when editing default rule, the field was wrongly addressed as required even if when editing it's a mere placeholder.

Ref:

@Tbaile Tbaile requested a review from andre8244 November 11, 2024 14:21
@Tbaile Tbaile self-assigned this Nov 11, 2024
Copy link
Collaborator

@andre8244 andre8244 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we ever need to modify again useRuleForm or usePolicyForm , I suggest renaming them, as it's difficult to recognize their connection to multiwan.

@Tbaile Tbaile merged commit 767d4a1 into main Nov 12, 2024
3 checks passed
@Tbaile Tbaile deleted the mwan-fix-default-rule-edit branch November 12, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done ✅
Development

Successfully merging this pull request may close these issues.

2 participants