Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hard dependency on git CLI available to the build system. #3999

Closed
MicahZoltu opened this issue May 3, 2022 · 1 comment
Closed

Comments

@MicahZoltu
Copy link
Contributor

Describe the bug
Previously, I could dotnet build ... on my machine without any problems. Now when I try I get the following error:

  ---> Generating Git Hash file Before Build
  'git' is not recognized as an internal or external command,
  operable program or batch file.
C:\...\src\Nethermind\Nethermind.Runner\Nethermind.Runner.csproj(119,5): error MSB3073: The command "git describe --tags --long --always > git-hash" exited with code 9009.

To Reproduce
Steps to reproduce the behavior:

  1. Install Windows 11
  2. Install dotnet SDK
  3. Acquire Nethermind source code
  4. cd src/Nethermind
  5. dotnet build --configuration Release Nethermind.sln
  6. Notice that the build fails

Expected behavior
I don't need any tooling besides dotnet to build.

Desktop (please complete the following information):

  • OS: Windows
  • Version: 1.12.8

Additional context
While I do have git installed, I don't have it on my path because I never use it from the CLI, I always use it from higher level tooling.

@LukaszRozmej
Copy link
Member

Fixed in #7131

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants