-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove totalDifficulty from block in json reponse #7397
Comments
@smartprogrammer93 Hello! I would like to do this, I come from dojo coding, I would like to contribute to the project! |
Hey @Elianfarias! |
@Elianfarias sure go ahead. |
Hi @smartprogrammer93! |
@smartprogrammer93 are we sure this is good idea? We still support AuRa and Clique networks, where total difficulty has meaning. We still support block explorers like blockscout which could use it. |
To be honest I wouldn't merge that PR. Just because Main Ethereum doesn't need it (and spec is about main Ethereum), doesn't mean we should remove it because our clients are using other consensus algorithms and may still need it. Just let it be until proven unnecessary. |
based on this merged PR:
ethereum/execution-apis#570
The text was updated successfully, but these errors were encountered: