Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove totalDifficulty from block in json reponse #7397

Closed
smartprogrammer93 opened this issue Sep 4, 2024 · 6 comments
Closed

Remove totalDifficulty from block in json reponse #7397

smartprogrammer93 opened this issue Sep 4, 2024 · 6 comments

Comments

@smartprogrammer93
Copy link
Contributor

based on this merged PR:
ethereum/execution-apis#570

@Elianfarias
Copy link

@smartprogrammer93 Hello! I would like to do this, I come from dojo coding, I would like to contribute to the project!

Copy link

onlydustapp bot commented Sep 5, 2024

Hey @Elianfarias!
Thanks for showing interest.
We've created an application for you to contribute to Nethermind.
Go check it out on OnlyDust!

@smartprogrammer93
Copy link
Contributor Author

@Elianfarias sure go ahead.

@Elianfarias
Copy link

Hi @smartprogrammer93!
I'm doing my first issue of the Nethermind project.
I understand the context, that the scheme underwent a change, the TotalDifficulty property in the Type Block was removed.
I see in the nethermind solution, there is a "Core" project in which the Block and HeaderBlock classes have the totalDifficulty property, should I delete it and fix the errors that the solution throws?
I don't know which section of discord to send this query, could you tell me so I don't bother you in private next time?

@LukaszRozmej
Copy link
Member

@smartprogrammer93 are we sure this is good idea? We still support AuRa and Clique networks, where total difficulty has meaning. We still support block explorers like blockscout which could use it.

@LukaszRozmej
Copy link
Member

To be honest I wouldn't merge that PR. Just because Main Ethereum doesn't need it (and spec is about main Ethereum), doesn't mean we should remove it because our clients are using other consensus algorithms and may still need it. Just let it be until proven unnecessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants