Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Grandine Consensus client support #383

Draft
wants to merge 12 commits into
base: develop
Choose a base branch
from
Draft

Add Grandine Consensus client support #383

wants to merge 12 commits into from

Conversation

khalifaa55
Copy link
Contributor

Closes #381

Changes:

  • Add Grandine Consensus and Validator client to network Mainnet.

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests?

  • Yes
  • No

@codecov-commenter
Copy link

codecov-commenter commented May 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.59%. Comparing base (398245d) to head (9b76264).

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop     #383   +/-   ##
========================================
  Coverage    86.59%   86.59%           
========================================
  Files           78       78           
  Lines         3977     3977           
========================================
  Hits          3444     3444           
  Misses         448      448           
  Partials        85       85
Flag Coverage Δ
unittests 86.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@khalifaa55 khalifaa55 marked this pull request as ready for review May 19, 2024 23:45
@kamilchodola
Copy link
Contributor

putting that for test with Nethermind client :)

@kamilchodola
Copy link
Contributor

@khalifaa55
Seems like it didn't worked for me:
./sedge generate --logging none -p /root full-node --map-all --no-mev-boost --no-validator --network mainnet -e nethermind:nethermindeth/nethermind:master -c grandine:sifrai/grandine:stable

@khalifaa55 khalifaa55 marked this pull request as draft May 28, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add grandine Consensus client support
4 participants
@khalifaa55 @codecov-commenter @kamilchodola @nishim3