Skip to content
This repository has been archived by the owner on Dec 6, 2024. It is now read-only.

Resolve the Grafana metrics discrepancies #211

Open
stranger80 opened this issue Oct 7, 2024 · 2 comments
Open

Resolve the Grafana metrics discrepancies #211

stranger80 opened this issue Oct 7, 2024 · 2 comments
Assignees
Milestone

Comments

@stranger80
Copy link
Contributor

stranger80 commented Oct 7, 2024

  • Ensure that "compilations" and "plugin launches" counters are also reflected in the Prod Grafana Dashboard
  • Filter out OPTIONS requests from 'metrics detection' code
  • Investigate the weird zksync_api_num_plugin_launches counter increase phenomenon for "prod" env:

image

@stranger80
Copy link
Contributor Author

stranger80 commented Oct 14, 2024

It appears that the compile and launch metrics currently in place are "double-counting" (OPTIONS requests being counted separately from GET/POST requests) - this will be adjusted.
It is unclear why historically the counter values have been reset around 30th Sept-1st Oct - this hasn't been triggered by container restarts and it can be demonstrated that plugin upgrades have not impacted the aggregated values on eg. 28th Sept.
As they have been stable in Oct, we'll continue with the rollout of current release and observe the results of that.

@taco-paco
Copy link
Contributor

#219

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: 👀 In review
Development

No branches or pull requests

2 participants