Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow node 16 in actions to build linux binary #558

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

denis-maiorov-brightsec
Copy link
Collaborator

Bypasses unsupported node versions check
Node 16 is required to build linux binaries compatible with old distros (see #449)

relates-to: actions/checkout#1809

Bypasses unsupported node versions check
Node 16 is required to build linux binaries compatible with old distros (see #449)

relates-to: actions/checkout#1809
@denis-maiorov-brightsec denis-maiorov-brightsec added the Type: bug Something isn't working. label Jul 10, 2024
@denis-maiorov-brightsec denis-maiorov-brightsec enabled auto-merge (squash) July 10, 2024 17:06
@denis-maiorov-brightsec denis-maiorov-brightsec merged commit 5db5178 into next Jul 10, 2024
6 checks passed
@denis-maiorov-brightsec denis-maiorov-brightsec deleted the fix/linux-build-issue branch July 10, 2024 17:06
@derevnjuk
Copy link
Member

@denis-maiorov-brightsec this is not enough. mirrorlist.centos.org has been deprecated July 1. You need to switch to the mirror.
@orubin fyi

@derevnjuk
Copy link
Member

@denis-maiorov-brightsec also, as you can see macos11 is not longer supported: https://github.com/NeuraLegion/bright-cli/actions/runs/9878683609/job/27283198266. it was removed at the end of June: https://github.blog/changelog/2024-05-20-actions-upcoming-changes-to-github-hosted-macos-runners/. You have to switch to macos12 at least

@orubin fyi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: bug Something isn't working.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants