Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(*): rename cluster option to hostname in the Configuration #102

Merged
merged 1 commit into from
May 25, 2022
Merged

feat(*): rename cluster option to hostname in the Configuration #102

merged 1 commit into from
May 25, 2022

Conversation

derevnjuk
Copy link
Member

closes #101

@derevnjuk derevnjuk added the Type: enhancement New feature or request. label May 25, 2022
@derevnjuk derevnjuk requested a review from pmstss May 25, 2022 13:42
@derevnjuk derevnjuk self-assigned this May 25, 2022
@derevnjuk derevnjuk force-pushed the feat_#101/rename_cluster_option_to_hostname_in_the_Configuration branch from 415f56b to 375d9a6 Compare May 25, 2022 13:42
@codeclimate
Copy link

codeclimate bot commented May 25, 2022

Code Climate has analyzed commit 375d9a6 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (80% is the threshold).

This pull request will bring the total coverage in the repository to 98.4%.

View more on Code Climate.

@pmstss
Copy link
Contributor

pmstss commented May 25, 2022

wasn't cluster at least consistent with nexpoit-cli parameter name? is it product decision? could it be e. g. brightHost for clear distinguishing from other (e.g. scan targets) hosts?

pmstss
pmstss approved these changes May 25, 2022
View reviewed changes
Copy link
Contributor

@pmstss pmstss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no complains on implementation side, but there are some doubts regarding rationality

@derevnjuk
Copy link
Member Author

@pmstss it was a product decision. Anyway, I don't see any issue with the name. We don't have hostname in other models, but even if Target contained something like this, it would have been in the different context

@derevnjuk derevnjuk merged commit bf1a7ef into master May 25, 2022
@derevnjuk derevnjuk deleted the feat_#101/rename_cluster_option_to_hostname_in_the_Configuration branch May 25, 2022 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmstss pmstss pmstss approved these changes

Assignees

@derevnjuk derevnjuk

Labels
Type: enhancement New feature or request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename cluster option to hostname in the Configuration
2 participants
@derevnjuk @pmstss