Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebSocket connection handshake does not break by timeout #121

Closed
denis-maiorov-brightsec opened this issue Sep 1, 2022 · 0 comments · Fixed by #122
Closed

WebSocket connection handshake does not break by timeout #121

denis-maiorov-brightsec opened this issue Sep 1, 2022 · 0 comments · Fixed by #122
Assignees
Labels
Type: bug Something isn't working

Comments

@denis-maiorov-brightsec
Copy link
Contributor

denis-maiorov-brightsec commented Sep 1, 2022

When the scan is attacking websocket endpoints and websocket server is not responding to initial connect, websocket requests are not timing out

Step to reproduce:

  1. Run a scan on target that has ws endpoints that do not respond
const scan = await this.scanFactory.createScan(
  {
    tests: [TestType.SQLI],
    name: TestType.SQLI,
    target: {
      url: '<stuck ws/wss target>'
    }
  }
);
  1. Call expect
await scan.expect(async () => {
  const issues = await scan.issues();
  return issues.length > 2;
});

Actual: requests are hanging and expect does not resolve
Expected: requests fail by timeout and expect resolves

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant