feat(scan): add a critical level to the severity #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit a656de2 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 97.9% (0.0% change). View more on Code Climate. |
derevnjuk
requested changes
Feb 8, 2023
|
@ostridm, the scope |
derevnjuk
changed the title
Severity enum with Critical leveladjust according to code review: #130 (comment) #130 (comment) #130 (comment) closes #129
derevnjuk
approved these changes
Feb 9, 2023
derevnjuk
deleted the
feat-#129/able-to-define-critical-severity-threshold
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce the ability to set the severity threshold to the
Criticallevel using thethresholdmethod:With this implementation, the scan will continue despite the presence of issues with a severity lower than
Critical, and will only stop for issues ofCriticalseverity.closes #129