-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Example] P300-VR dataset #393
Conversation
fix: inversion 12 blocks of 5 repetitions
Thanks @gcattan |
# Conflicts: # moabb/tests/datasets.py
Yes, sorry, I forgot to replace all occurrences of the dataset code on the first PR. |
When using this code:
I have the following error:
|
In this branch? |
In the moabb develop branch. |
Seems to be solved now. |
dataset.virtual_reality = condition == "VR" | ||
dataset.personal_computer = condition == "PC" | ||
|
||
# cross validate with 3-folds validation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not use a WithinSessionEvaluation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to demonstrate the use of the get_block_repetition
method.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, in that case, you should add a small text it in the example to explain get_block_repetition
method and to indicate that this example use it.
Co-authored-by: Sylvain Chevallier <sylvain.chevallier@universite-paris-saclay.fr>
I made the modification. Do you want me to conduct other validation? |
Hi @gcattan, Many thank you for your contribution! I appreciate your effort in creating this tutorial. However, I noticed that the tutorial lacks proper structuring and detailed comments, which makes it difficult for readers to follow along seamlessly. To improve the tutorial, I suggest implementing the following changes:
To check the doc render in the pull request, when the doc generation finished, you will need to click on the Docs / build_docs (ubuntu-latest, 3.9) (pull_request) Details, Summary (top left), scroll down the page and click in Artifacts (DocumentationHTML). Please let me know if you have any questions or need further clarification. I'm here to assist you with the review process. |
Thank you @gcattan! All good for me! |
Thanks :) |
Thanks @gcattan for nice addition and example, and kudo @bruAristimunha for the review 🙏 |
This PR is a follow-up for #358. It:
@plcrodrigues FYI