Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dataset_search finds both the depreciated and new dataset names #476

Closed
PierreGtch opened this issue Aug 30, 2023 · 4 comments · Fixed by #504
Closed

dataset_search finds both the depreciated and new dataset names #476

PierreGtch opened this issue Aug 30, 2023 · 4 comments · Fixed by #504
Labels
Milestone

Comments

@PierreGtch
Copy link
Collaborator

Since #464, dataset_search will return both the depreciated and the new name of each dataset. Also, it raises a warning for every depreciated dataset because they are all initialized.

@PierreGtch PierreGtch added the bug label Aug 30, 2023
@sylvchev
Copy link
Member

@PierreGtch could you check if it is still the case?

@PierreGtch
Copy link
Collaborator Author

@sylvchev it’s still the case rn but removing them is simple (see PR).

The issue is that I don't know if some applications need to also have the old names in the search results. Is this a breaking change?

@sylvchev
Copy link
Member

For me this is not a breaking change as the new names are the one that should be used. Better not advertise deprecated names.

@PierreGtch
Copy link
Collaborator Author

ok then we can merge #504

@PierreGtch PierreGtch added this to the 1.0.0 milestone Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants