Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bookmarks Menu is always in the list to update #20

Closed
perfect7gentleman opened this issue May 27, 2020 · 1 comment
Closed

Bookmarks Menu is always in the list to update #20

perfect7gentleman opened this issue May 27, 2020 · 1 comment
Assignees

Comments

@perfect7gentleman
Copy link

https://chrome.google.com/webstore/detail/bookmarks-menu/ffmdedmghpoipeldijkdlcckdpempkdi

IMO, the problem is that different versioning is used. 2020.02.02.1 is in WebStore and 2020.2.2.1 is in Extensions tab.

@NeverDecaf
Copy link
Owner

This seems to be happening because the version string used by that extension is invalid according to the documentation. Specifically, A couple of rules apply to the integers: they must be between 0 and 65535, inclusive, and non-zero integers can't start with 0. It appears chromium just strips the leading zeroes instead of rejecting the version number, which leads to this mismatch.

chromium-web-store currently just compares the 2 strings without any regard for the rules or even whether the "new" version number is higher than the old. I will implement the version comparison chromium appears to use (split by '.' and convert to int) which should fix your problem and prevent any accidental downgrades in the future.

@NeverDecaf NeverDecaf self-assigned this May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants