Logging providers cause issues in unit test context

[AlexEngblom]

We use NLog in our solution. It seems that LibLog resolves and initializes NLog provider with the configuration we have in the project root. This means that Malware scanner tries to internally write according to our default nlog configuration when running unit tests. This even causes tests to crash when they try to resolve NLog db connection while lacking permissions.

As a workaround we clear the NLog configuration via static access point at the start of unit test
LogManager.Configuration = new NLog.Config.LoggingConfiguration();

However I think this is an ugly and unwanted side effect.
Maybe this could be avoided by using ILogger interface and dependency injection approach instead. Let the software always decide the implementation instead of sniffing for usable providers.

[flytzen]

That is a good point; LibLog has now been deprecated in favour of ILogger (damianh/LibLog#270) so it's time for this package to change with the times.

[flytzen]

Note to self; inject ILogger, not ILogger<T> as per https://blog.rsuter.com/logging-with-ilogger-recommendations-and-best-practices/

[flytzen]

@AlexEngblom I've pushed a 1.0.0-beta1 version here: https://www.nuget.org/packages/MalwareScan.AMSI/1.0.0-beta1 (may be a few minutes before it shows up). I have simply removed LibLog as I am not sure there is that much value in logging?
Would you mind taking it for a spin and let me know if it suits? I'll push a format v.1 after that.

[AlexEngblom]

Works without issues, thank you. I suppose logging is not a mandatory, however it would be nice to have a way to see what happened under the hood (detection information). The result for .HasVirus() is just a boolean, so it doesn't give that much information of what was detected and so on.

[flytzen]

Thanks @AlexEngblom; I have pushed v1 now.
I have opened another issue #3 to add support for ILogger.