Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render edited messages #402

Closed
slondr opened this issue Jan 22, 2021 · 1 comment · Fixed by #420
Closed

Render edited messages #402

slondr opened this issue Jan 22, 2021 · 1 comment · Fixed by #420
Labels
enhancement New feature or request

Comments

@slondr
Copy link

slondr commented Jan 22, 2021

Is your feature request related to a problem? Please describe.
Probably the most immediately-visible difference that makes Nheko look more unrefined/unpolished compared to big-name clients like Element is the ugly handling of edited messages. If someone edits a message, the old message remains and the new one is reprinted with an asterisk in front — this often results in my entire chat window filling up with a single message, or very old messages reappearing when they shouldn't. This is both very ugly and also occasionally prevents me from easily reading the chat history.

Describe the solution you'd like
The content of messages should change when they are edited, instead of remaining + a new message appearing.

@slondr slondr added the enhancement New feature or request label Jan 22, 2021
@deepbluev7
Copy link
Member

Kinda duplicate to #134. The problem is that I disagree with the current proposal for edits (it is not officially part of the matrix spec at this point). Which is why I didn't implement it, since I was hoping for either the proposal to get fixed or it at least get merged into the spec officially. I probably need to implement it at some point now though, since explaining that every time again is no fun...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants