Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Q: SignalR for automatic fallback? #3

Open
zakaluka opened this issue Jun 26, 2018 · 4 comments
Open

Q: SignalR for automatic fallback? #3

zakaluka opened this issue Jun 26, 2018 · 4 comments
Milestone

Comments

@zakaluka
Copy link

Hi @Nhowka,

I have a question on fallbacks. Is there a plan to use / upgrade to https://github.com/aspnet/SignalR so that Elmish.Bridge can take advantage of automatic fallbacks? According to https://docs.microsoft.com/en-us/aspnet/core/fundamentals/websockets?view=aspnetcore-2.1, using Microsoft.AspNetCore.WebSockets requires the developer (aka either you or the app developer) to implement fallback to alternative transport protocols.

Would love to hear your thoughts on this.

Thank you

@Nhowka
Copy link
Owner

Nhowka commented Jun 26, 2018

Good thinking! I'll check the impact on bundle size if any and if I can keep the ServerHub as it is or give some access to SignalR Hub.

@Nhowka
Copy link
Owner

Nhowka commented Jul 26, 2018

I'm not sure if it will be needed... Looks like there is good support for it:
https://caniuse.com/#feat=websockets

As Elmish doesn't do much with javascript disabled, maybe it will be unnecessary complexity.

@Nhowka Nhowka closed this as completed Jul 26, 2018
@0x53A
Copy link
Contributor

0x53A commented Aug 28, 2018

For us the issue is not the browsers themselves, but rather intercepting proxies / firewalls, which are unfortunately common in corporate environments.

Have you already taken a look at how much effort it would be to model Elmish.Bridge on top of SignalR, or whether the SignalR communication layer can be extracted out?

@Nhowka
Copy link
Owner

Nhowka commented Aug 28, 2018

That's fair. Now that there's a possibility of having more options, I'll do it as a choice and if it works well I'll make it the default. I hope I can work on it soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants