Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure frontend and contract are applying same fees in the context of borrower refinance #580

Open
zjmiller opened this issue Feb 14, 2023 · 1 comment
Assignees

Comments

@zjmiller
Copy link
Collaborator

No description provided.

@zjmiller zjmiller self-assigned this Feb 14, 2023
@kumarvivekpandey
Copy link

Hi Zjmiller,

I'm interested in working on this issue. To ensure that the frontend and contract apply the same fees in the context of borrower refinance, I'll follow these steps:

  1. Analysis: I'll start by thoroughly understanding the existing codebase and the logic related to fees in both the frontend and contract.

  2. Comparison: I'll compare the fee calculation logic in the frontend with that in the contract to identify any discrepancies or differences.

  3. Sync Logic: If there are differences, I'll work on aligning the fee calculation logic so that both the frontend and contract use the same logic and parameters.

  4. Testing: After implementing the changes, I'll conduct rigorous testing to ensure that the fees are consistently applied in both environments.

  5. Documentation: I'll update relevant documentation to reflect the changes made and ensure that future developers have clear guidance.

Please assign this issue to me, and I'll get started right away. If there are specific details or requirements I should be aware of, please let me know.

Looking forward to contributing to this project.

Best regards,
VIvek

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants