Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow ApiException to force stack trace logging even for 4xx, or suppress for 5xx #44

Closed
nicmunroe opened this issue Sep 13, 2019 · 1 comment
Closed

Allow ApiException to force stack trace logging even for 4xx, or suppress for 5xx #44

nicmunroe opened this issue Sep 13, 2019 · 1 comment

Comments

@nicmunroe
Copy link
Member

The current logic in ApiExceptionHandlerBase.shouldLogStackTrace(...) returns false for 4xx errors (no stack trace in the logs), and true for everything else (yes stack trace in the logs).

We should add a field to ApiException to allow users to override this default behavior and force stack trace on/off if they want to override the default 4xx vs. 5xx decision behavior.
@nicmunroe nicmunroe changed the title Allow ApiException to force stack trace logging even for 4xx Allow ApiException to force stack trace logging even for 4xx, or suppress for 5xx Sep 13, 2019
@nicmunroe
Copy link
Member Author

Fixed by PR #47 and #48, released in version v0.13.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nicmunroe