Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI for submodules updates #289

Open
nkaskov opened this issue Oct 9, 2023 · 1 comment
Open

Add CI for submodules updates #289

nkaskov opened this issue Oct 9, 2023 · 1 comment
Assignees

Comments

@nkaskov
Copy link
Contributor

nkaskov commented Oct 9, 2023

We constantly need to test our updates. The problem is that updates in submodules may depend on each other - and we need to test it before merging the updates.

Currently, we need to do it manually, which gives us a lot of pain.

A perfect user story looks like that:

  1. Developer starts developing from an issue in zkllvm repository
  2. (Assuming that this issue requires changes in both assigner and circifier) - developer makes changes in feature-branches and creates PRs in all repos (except from zkllvm repository - because zkllvm PR requires merging PRs in submodules first)
  3. Dependent PRs are being detected by a bot. It runs dependent testing on corresponding branches.
  4. If all good - Bot approves all PRs
  5. Another developer approves these PRs.
  6. PRs in submodules rebase to master
  7. Bot creates PR in zkllvm (I am not sure if we need this step).

Maybe this can be done by giving branches the same names. It is not very convenient, and it also depends on human factor.

Another option - keywords or labels in PRs. This would require a minimum job done by the developer to trigger correct bot behavior.

@nil-foundation-cicd-bot
Copy link

nil-foundation-cicd-bot bot commented Nov 25, 2023

PRs, synced with the current issue:

Note: Please do not edit this comment; it's generated automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

3 participants