-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Component testing framework assumes all constants are placed in a single column. #282
Comments
Sure, I can modify the framework so that it just uses all the "unassigned" constant columns for lookup table packing. AFAIK currently the compiler is also assuming that all components use not more than a single constant column. As for the stretcher: this is correct, but I am unsure if we are going to change this soon; we might rely more on manually implementing different variants of components, or consider different automation approaches. |
https://github.com/NilFoundation/zkllvm-blueprint/blob/93b6463d8d6378e08994c3208fbed34f90b30fa7/test/test_plonk_component.hpp#L286C38-L286C38
The component tester assumes that all components use at most 1 column for constants. We have components that in some configurations where the component fits into a single row, we require 2 constants, and therefore 2 constant columns.
Could the testing framework not get the number of used constant columns from the component itself?
Furthermore, the component stretcher also assumes that there is at most 1 constant column.
The text was updated successfully, but these errors were encountered: