Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash with Compact Machines #1141

Closed
Old-Man-D opened this issue Apr 24, 2019 · 8 comments
Closed

Crash with Compact Machines #1141

Old-Man-D opened this issue Apr 24, 2019 · 8 comments

Comments

@Old-Man-D
Copy link

Modpack version
1.61

Can the issue be reproduced?
Yes

Logs
https://pastebin.com/K8xvj5wf

Issue
If you try and use the preview button to enter a compact machine while the tool is in your inventory, but not in your hand, it crashes. Entering the machine directly with the tool is fine.

@NielsPilgaard
Copy link
Collaborator

Does this happen with version 1.62?

@NielsPilgaard NielsPilgaard added the Status: Awaiting Information Waiting for additional information label Apr 24, 2019
@Frikkle
Copy link

Frikkle commented Apr 24, 2019

Just tested this on 1.62 in both SP and MP; cannot reproduce. Tried this with the Personal Shrinking Device in all types of slots (inventory, hotbar, off-hand, etc.).

An issue I did come across is that if you try to change the Machine's name; and click the checkmark box, the server does kick you with a "Connection Lost. - A fatal error has occured, this connection is terminated" error.

Server side logs here.

So if @Old-Man-D indeed means the preview button; I cannot reproduce. If he means the name changing thing I can confirm. So we should then either adjust this issue to reflect the name-change thing or create a new one for it.

Edit: the name-change disconnect issue only happens in MP; SP it behaves fine.
Edit2: I must mention that I'm currently running my own compiled version of CM 3.0.17 with the NPE-fixes for the RedstoneTunnel. That code however is extremely unlikely to be of any influence here.
Edit3: Tested 1.62 with stock CM 3.0.17; cannot reproduce.

@Old-Man-D
Copy link
Author

I’m not using any tunnels on these compact machines yet. I will update tonight to 1.62 and let you know my results. But specifically, I am talking about the little button that appears in the lower right corner of the preview window, when the shrinking device is present in your inventory.

@no-response no-response bot removed the Status: Awaiting Information Waiting for additional information label Apr 24, 2019
@Frikkle
Copy link

Frikkle commented Apr 24, 2019

I am talking about the little button that appears in the lower right corner of the preview window, when the shrinking device is present in your inventory.

Yeah; that is the preview button indeed. I cannot reproduce that on 1.62. I'm installing 1.61 now to check this in singleplayer. Could you confirm that the preview also causes a crash for you when the shrinking device is in your inventory but not in your hand?

@Old-Man-D
Copy link
Author

Also, I’m using a server FYI, in case that makes a difference

@Frikkle
Copy link

Frikkle commented Apr 24, 2019

It does make a difference; I just wondered if it also crashes in single player for you. That might help in pinpointing the behavior. I don't have a 1.61 server running anymore so I can't easily debug this on 1.61 MP.

@Frikkle
Copy link

Frikkle commented Apr 24, 2019

Update: I can't reproduce it on 1.61 stock in SP.

@NielsPilgaard
Copy link
Collaborator

The preview crash was fixed by 1.62

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants