Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate Squeezer / Fermenter recipes #1515

Merged
merged 2 commits into from
Feb 4, 2020

Conversation

Lgmrszd
Copy link
Contributor

@Lgmrszd Lgmrszd commented Feb 4, 2020

Few vanilla seeds/vegetables have both oredict entry used in this script and recipe already added by IE, which led to recipes duplication (example), so I decided to blacklist those items.

@Lgmrszd
Copy link
Contributor Author

Lgmrszd commented Feb 4, 2020

Another solution would be deleting recipes for blacklisted items first, to make sure that all plants produce 80mb per item, I'm not sure which one is better.

@NielsPilgaard
Copy link
Collaborator

Hi, thanks for the PR!
I would prefer the latter solution, if you wouldn't mind the extra work :)

@NielsPilgaard NielsPilgaard added Enhancement Script This issue relates to scripts in general labels Feb 4, 2020
@Lgmrszd
Copy link
Contributor Author

Lgmrszd commented Feb 4, 2020

I decided to do first one because it would be strange to have different plants produce equal amounts of oil (compared to Forestry Squeezer), but going through all Harvestcraft crops/seeds would be too much work, so I guess that works.

@NielsPilgaard NielsPilgaard merged commit 1aebbd3 into EnigmaticaModpacks:master Feb 4, 2020
@NielsPilgaard
Copy link
Collaborator

Looks good to me, thank you :)

SSyl pushed a commit to SSyl/Enigmatica2Expert-SSylTweaks that referenced this pull request Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Script This issue relates to scripts in general
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants