You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
roberth opened this issue
Jul 23, 2024
· 7 comments
Labels
featureFeature request or proposalfetchingNetworking with the outside (non-Nix) world, input lockingnew-cliRelating to the "nix" commandUXThe way in which users interact with Nix. Higher level than UI.
Is your feature request related to a problem? Please describe.
It's often useful to build or run something from a PR, especially when reviewing.
Let's make this easier.
Describe the solution you'd like
Step 1: CLI only
GitHub already supports a magic ref, like github:NixOS/nix?ref=refs/pull/11159/merge
We could provide a shorthand for this, like github:NixOS/nix?merge=11159
These merge commits, as well as commits in the PR tend to disappear, so it's doesn't make sense to lock this by rev sha.
Print a little notice when the PR has been merged, to let the user remove the merge parameter.
Step 2: Locking
Store the diff in the lock file or a location relative to it.
This would make it viable for use in pure-eval mode and real locking.
Step 3: Multiple
Multiple PRs could be merged in a single fetching. GitHub doesn't do this for us, so this would need the logic of Step 2, which needs to implement its own patching anyway.
The text was updated successfully, but these errors were encountered:
roberth
added
feature
Feature request or proposal
UX
The way in which users interact with Nix. Higher level than UI.
new-cli
Relating to the "nix" command
fetching
Networking with the outside (non-Nix) world, input locking
labels
Jul 23, 2024
You can just write github:NixOS/nix/pull/11159/merge (or /head), which is pretty ergonomic already. I do this all the time. Not sure if the juice is worth the squeeze? But I’m not opposed either.
Maybe for a flake that contains more configs (such as flake for NixOS), it will be helpful to directly merge multiple PRs in inputs.
Multiple PRs could be merged in a single fetching. GitHub doesn't do this for us, so this would need the logic of Step 2, which needs to implement its own patching anyway.
featureFeature request or proposalfetchingNetworking with the outside (non-Nix) world, input lockingnew-cliRelating to the "nix" commandUXThe way in which users interact with Nix. Higher level than UI.
Is your feature request related to a problem? Please describe.
It's often useful to build or run something from a PR, especially when reviewing.
Let's make this easier.
Describe the solution you'd like
Step 1: CLI only
GitHub already supports a magic
ref
, likegithub:NixOS/nix?ref=refs/pull/11159/merge
We could provide a shorthand for this, like
github:NixOS/nix?merge=11159
These merge commits, as well as commits in the PR tend to disappear, so it's doesn't make sense to lock this by
rev
sha.Print a little notice when the PR has been merged, to let the user remove the
merge
parameter.Step 2: Locking
Store the diff in the lock file or a location relative to it.
This would make it viable for use in
pure-eval
mode and real locking.Step 3: Multiple
Multiple PRs could be merged in a single fetching. GitHub doesn't do this for us, so this would need the logic of Step 2, which needs to implement its own patching anyway.
Describe alternatives you've considered
Additional context
Priorities
Add 👍 to issues you find important.
The text was updated successfully, but these errors were encountered: