Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pre-commit, editorconfig, nixpkgs-fmt? #7634

Closed
roberth opened this issue Jan 18, 2023 · 2 comments · Fixed by #7745
Closed

pre-commit, editorconfig, nixpkgs-fmt? #7634

roberth opened this issue Jan 18, 2023 · 2 comments · Fixed by #7745
Labels
contributor-experience Developer experience for Nix contributors

Comments

@roberth
Copy link
Member

roberth commented Jan 18, 2023 •
edited
Loading

Is your feature request related to a problem? Please describe.

Saw some unproductive comments about formatting today. Nothing too bad, but we could prevent this.

Describe the solution you'd like

  • nixpkgs-fmt
  • pre-commit-hooks.nix configuration that installs the hook in shellHook
  • .git-blame-ignore-revs file, now also supported by GitHub web app

Describe alternatives you've considered

Carry on.

Additional context

I think we can just vote among the Nix Team and I'll be happy either way.

Priorities

Add 👍 to issues you find important.
@roberth roberth added feature Feature request or proposal contributor-experience Developer experience for Nix contributors labels Jan 18, 2023
@roberth roberth added this to Nix team Jan 18, 2023
@edolstra
Copy link
Member

See #6721 for C++ formatting.

@roberth roberth mentioned this issue Feb 3, 2023
Draft
14 tasks
@roberth
Copy link
Member Author

roberth commented Feb 3, 2023

We could start by excluding existing files from the C++ formatter, in order not to hinder existing PRs with unnecessary conflicts.

@edolstra edolstra moved this to ⏰ Postponed in Nix team Feb 3, 2023
@roberth roberth mentioned this issue Feb 3, 2023
Merged
7 tasks
@roberth roberth removed the feature Feature request or proposal label Jun 29, 2023
@thufschmitt thufschmitt removed this from Nix team Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
contributor-experience Developer experience for Nix contributors
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add pre-commit hook and CI check, excluding currently unformatted files hercules-ci/nix
2 participants
@roberth @edolstra