Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically mention potential reviewers on pull-requests using mention-bot #11160

Closed
spwhitt opened this issue Nov 19, 2015 · 7 comments
Closed

Automatically mention potential reviewers on pull-requests using mention-bot #11160

spwhitt opened this issue Nov 19, 2015 · 7 comments
Labels
0.kind: enhancement Add something new
Milestone
16.03

Comments

@spwhitt
Copy link
Contributor

spwhitt commented Nov 19, 2015

Recently there was some discussion (probably in a NixCon video) that we should have some way to mention people on pull requests which they may be interested in. Facebook just released this bot which uses git blame to guess who to mention, and it requires 0 effort on our part to integrate. Maybe we should try it?

Obviously it would be nice to have a bot which uses the maintainer information embedded in nixpkgs, but that would take time to code and doesn't seem likely to actually happen. On the other hand, mention-bot could be set up and running one minute from now, so I suggest we try it.
@davidak
Copy link
Member

davidak commented Nov 20, 2015

@garbas mentioned it in his talk at http://youtu.be/PjAmr22FZts?t=27m42s

from a quick look this seams to be great. we should try it out!

@domenkozar
Copy link
Member

Awesome!

@domenkozar domenkozar mentioned this issue Nov 20, 2015
Closed
13 tasks
@nbp nbp added the 0.kind: enhancement Add something new label Nov 20, 2015
@nbp nbp added this to the 16.03 milestone Nov 20, 2015
@Mathnerd314
Copy link
Contributor

cc @edolstra @rbvermaa since they seem to be the only people with sufficient privilege level

@nbp
Copy link
Member

nbp commented Nov 21, 2015

👍 We definitely need something to scale with the increasing number of pull-requests.

@abbradar abbradar mentioned this issue Nov 22, 2015
Merged
@pSub
Copy link
Member

pSub commented Nov 22, 2015

👍

@spwhitt
Copy link
Contributor Author

spwhitt commented Nov 23, 2015

Bot seems to have been enabled, so closing this issue. Hope it proves to be useful!

@spwhitt spwhitt closed this as completed Nov 23, 2015
@pSub
Copy link
Member

pSub commented Nov 23, 2015

Good news!

@fpletz fpletz mentioned this issue Feb 26, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0.kind: enhancement Add something new
Projects
None yet
Milestone
16.03
Development

No branches or pull requests
6 participants
@pSub @davidak @domenkozar @Mathnerd314 @nbp @spwhitt