Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p7zip fails to cross-compile to mingw #195366

Closed
Thesola10 opened this issue Oct 10, 2022 · 4 comments
Closed

p7zip fails to cross-compile to mingw #195366

Thesola10 opened this issue Oct 10, 2022 · 4 comments
Labels
0.kind: enhancement Add something new 0.kind: packaging request Request for a new package to be added 6.topic: windows Running, or buiding, packages on Windows 9.needs: upstream fix This PR needs upstream to change something

Comments

@Thesola10
Copy link
Contributor

Steps To Reproduce

Steps to reproduce the behavior:

  1. nix-shell -p pkgsCross.mingwW64.p7zip

Build log

gist

Additional context

This can be useful to bundle cross-compiled executables into self-extracting archives, entirely within the Nix environment.

Notify maintainers

@7c6f434c @06kellyjac

Metadata

  • system: "x86_64-linux"
  • host os: Linux 5.19.10-arch1-1, Arch Atomic, noversion, rolling
  • multi-user?: yes
  • sandbox: yes
  • version: nix-env (Nix) 2.10.3
  • channels(karim): "git-goodies, nixgl, nixos-22.05, nixpkgs, sops"
  • channels(root): "nixpkgs"
  • nixpkgs: /home/karim/.nix-defexpr/channels/nixpkgs
@Thesola10 Thesola10 added the 0.kind: build failure A package fails to build label Oct 10, 2022
@06kellyjac 06kellyjac added 0.kind: enhancement Add something new 0.kind: packaging request Request for a new package to be added and removed 0.kind: build failure A package fails to build labels Oct 10, 2022
@06kellyjac
Copy link
Member

mingw isn't a marked as a supported target within nixpkgs so we wouldn't expect this to work & this is a request to support it.

As a note does https://github.com/jinfeihan57/p7zip actually support cross compiling to mingw? I'm not seeing many mentions there
The only mention I've found is a closed PR that says it adds "Can build mingw edition on Linux"
https://github.com/jinfeihan57/p7zip/pull/172

I'm thinking this requires upstream changes first

@06kellyjac 06kellyjac added the 9.needs: upstream fix This PR needs upstream to change something label Oct 10, 2022
@veprbl veprbl added the 6.topic: windows Running, or buiding, packages on Windows label Oct 14, 2022
@AtnNn
Copy link
Contributor

AtnNn commented Feb 21, 2023

@Thesola10 Would 7zz work for you instead? It seems easier to get to cross-compile with mingw: #217472

@Thesola10
Copy link
Contributor Author

@AtnNn can 7zz build self-extracting archive executables like 7z? If so then that's fine by me

@06kellyjac
Copy link
Member

06kellyjac commented Feb 21, 2023

λ nix run nixpkgs#p7zip -- --help | grep sfx
  -sfx[{name}] : Create SFX archive
λ nix run nixpkgs#_7zz -- --help | grep sfx
  -sfx[{name}] : Create SFX archive

Looks like it

I will close this for now since again I think it requires some upstream changes and #217472 is merged now.
Once upstream p7zip supports mingw and someone wants p7zip instead of _7zz then I'm happy to revisit this


As a note the issue I linked in my comment above is now gone since the p7zip repo no longer has issues enabled

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: enhancement Add something new 0.kind: packaging request Request for a new package to be added 6.topic: windows Running, or buiding, packages on Windows 9.needs: upstream fix This PR needs upstream to change something
Projects
None yet
Development

No branches or pull requests

4 participants