-
-
Notifications
You must be signed in to change notification settings - Fork 15.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
budgie-desktop crashes when searching in budgie menu #228142
Comments
Backtrace points to https://github.com/BuddiesOfBudgie/budgie-desktop/blob/v10.7.1/src/appindexer/RelevancyService.vala#L185
Looks like there are changes on |
I gave the latest HEAD (i.e. BuddiesOfBudgie/budgie-desktop@f49821a) a try and cannot reproduce the issue so probably some of the commits fixes the issue. I wonder if this can be reproduce by others and if some fixes can be backported before 23.05 |
Ohhh goooooood and now I am reading |
And now I am on 45d0a21, which has glib 2.74 (830de34 has 2.76). This is going to be weird because with G_SLICE=always-malloc I also cannot reproduce the crash (budgie-desktop 10.7.1), so probably not related to the slice allocator. Edit: and it's vala 0.56.4 on 45d0a21 (no crash) and 0.56.6 on 830de34 (crash) |
Okay I guess I can basically confirm it's caused by vala update because I am now on 8722936 and cannnot reproduce the crash, wow it's first time I know valac can really cause issues 🙈 Bisect is too painful for my slow laptop 🙃 |
Could you try compiling and running this Vala code on the broken version to see if it also crashes? It should do the same thing as the crashing Budgie code, just without crashing your desktop. If this ends up being a Vala issue, we need a minimal reproduction program to send. int matrix_test()
{
var matrix = new int[5, 5];
// Initalize the array columns
for (int i = 0; i < 5; i++)
{
matrix[i, 0] = i;
}
for (int j = 0; j < 5; j++)
{
matrix[0, j] = j;
}
// Set stuff to the array
for (int i = 0; i < 5; i++)
{
for (int j = 0; j < 5; j++)
{
matrix[i, j] = 10;
}
}
// Return the element at the end of the matrix
return matrix[4, 4];
}
int main()
{
var i = matrix_test();
message("result: %d", i);
return 0;
} Build and run with (assuming you put it in a file called
|
I am now on 722bc3b and my desktop crashes, so the current range is GNOME/vala@0.56.4...0.56.5 🙃 I am away from keyboard for the next few hours because it's midnight here but feel free to drop questions 🙃 I built the program with vala 0.56.5, it exits normally with
|
Well, crap. I was hoping that would crash. Maybe this version when you get back? It's closer to the code in Budgie: int matrix_test()
{
var matrix = new int[5, 5];
// Initalize the array columns
for (int i = 0; i < 5; matrix[i, 0] = i++) {}
for (int j = 0; j < 5; matrix[0, j] = j++) {}
// Set stuff to the array
for (int i = 0; i < 5; i++)
{
for (int j = 0; j < 5; j++)
{
var cost = 10;
matrix[i, j] = cost;
}
}
// Return the element at the end of the matrix
return matrix[4, 4];
}
int main()
{
var i = matrix_test();
message("result: %d", i);
return 0;
} Of those commits, the only one that really looks suspicious to me is GNOME/vala@1851080 at a glance. |
I am still here (for now) 😆 but this runs normally for me as well
(hmmm can we really guarantee "if I can trigger the desktop crash, then using same vala same laptop same setup we can trigger a crash with some different program"?) |
Describe the bug
When typing something here:
The desktop crashes and you have to re-login (well it's Chinese in the screenshot but I hope you get the idea)
Steps To Reproduce
Steps to reproduce the behavior:
Expected behavior
No crash.
Screenshots
See above.
Additional context
I don't see this issue before the GNOME 44 update. Probably another issue caused by GLib 2.76 but I haven't go deep yet.
Notify maintainers
@FedericoSchonborn
Metadata
I am on https://github.com/NixOS/nixpkgs/commits/830de34f05ba01959cec62a6e47e91547b07fc66 right now, it's nixos-unstable with pull request #227526 picked.
The text was updated successfully, but these errors were encountered: