Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nox-review is broke #24261

Closed
ndowens opened this issue Mar 24, 2017 · 1 comment
Closed

Nox-review is broke #24261

ndowens opened this issue Mar 24, 2017 · 1 comment

Comments

@ndowens
Copy link
Contributor

ndowens commented Mar 24, 2017

Issue description

I believe #24133 caused nox-review to break as it gives undefind variable gtk in qt-5/5.7.nix

When looking at the changes I see gtk3 defind, but below i see gnome3.gtk(which would be the undefind one)

Steps to reproduce

nox-review anything

Technical details

  • System: (NixOS: nixos-version, Ubuntu/Fedora: lsb_release -a, ...)
  • Nix version: (run nix-env --version)
  • Nixpkgs version: (run nix-instantiate --eval '<nixpkgs>' -A lib.nixpkgsVersion)
@globin
Copy link
Member

globin commented Mar 24, 2017

Fixed on 17.03 at least, thought those were caused by cherry-picking, checking master right now.

Edit: looks good

@globin globin closed this as completed Mar 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants