Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ytui-music is not working on my end #258033

Open
idlip opened this issue Sep 29, 2023 · 6 comments
Open

ytui-music is not working on my end #258033

idlip opened this issue Sep 29, 2023 · 6 comments
Labels
0.kind: bug Something is broken

Comments

@idlip
Copy link
Contributor

idlip commented Sep 29, 2023

Describe the bug

I did try it with nix shell github:nixos/nixpkgs/master#ytui-music with version 2.0.0 beta.

This is the verbose traceback with RUST_BACKTRACE=full : https://dpaste.org/GjDCz

Steps To Reproduce

Steps to reproduce the behavior:

  1. nix shell github:nixos/nixpkgs/master#ytui-music
  2. run ytui_music run

Notify maintainers

@kashw2 (since you packaged it)

Metadata

Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.

[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.5.2, NixOS, 23.11 (Tapir), 23.11.20230915.ace5093`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.17.0`
 - channels(root): `"nixos"`
 - channels(i): `""`
 - nixpkgs: `/nix/store/6s86padm2iikrwhlq8nwfv0lw9d1sbvq-source`
@idlip idlip added the 0.kind: bug Something is broken label Sep 29, 2023
@kashw2
Copy link
Contributor

kashw2 commented Sep 29, 2023

Hey, I've done some digging on this issue and it looks like it's related to sudipghimire533/ytui-music#35.

I'll look to add a patch for this as the developer says in that issue they've fixed it (my guess is that it is apart of the main tag).

Looking at upstreams tags the latest at this time is the main tag. If this does contain a fix it presents a problem of the packages versioning scheme being easy to misunderstand if we were to update to it (which is why a patch is probably the best solution here).

@idlip
Copy link
Contributor Author

idlip commented Sep 29, 2023

My bad, i didnt even search issues there. Thought it was with packaging.

No worries, sooner or later it might be fixed.

Thank you for packaging it!

@idlip
Copy link
Contributor Author

idlip commented Sep 29, 2023

Oh wait issue seems to be solved with respect to adding libmpv-rs.

The current package is behind one tag/release.
Should probably update the package to main and call it 2.0.0 ?

@kashw2
Copy link
Contributor

kashw2 commented Sep 29, 2023

We could update to the main tag. The only worry I have is breaking interop with tools like nix-update.

In the case of nix-update my main concern would be it getting the tag wrong and updating to the wrong version if ever upstream was to start using proper semver or another numerical versioning scheme after the main tag and associated release.

For example, we update the version to match the main tag upstream and upstream releases 3.0.0. I'm not sure if nix-update would update the package to 3.0.0 as desired or if it'd keep it as main.

I'll look into this and see what the best route to take would be to fix this.

@nixos-discourse
Copy link

This issue has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/how-can-i-install-ytui-music/42941/4

@Tychology
Copy link

Is there any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: bug Something is broken
Projects
None yet
Development

No branches or pull requests

4 participants