You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
cctag is currently compiled with libEigen alignment disabled, although it should be possible to enable in on modern compilers (see https://github.com/alicevision/CCTag/blob/develop/src/CMakeLists.txt#L250). When libEigen alignment are disabled in cctag, reverse dependencies that link to cctag also need to disable libEigen alignments in order to ensure binary compatibility.
Steps To Reproduce
Steps to reproduce the behavior:
build cctag
look into $dev/lib/cmake/CCTag/CCTagTargets.cmake
see these exported definitions: EIGEN_MAX_ALIGN_BYTES=0;EIGEN_MAX_STATIC_ALIGN_BYTES=0
Expected behavior
cctag does not export definitions that disable libEigen alignments (e.g. EIGEN_MAX_ALIGN_BYTES=0;EIGEN_MAX_STATIC_ALIGN_BYTES=0)
Additional context
With this being fixed, AliceVision could be compiled with libEigen alignments and cctag support here: #256115
Describe the bug
cctag
is currently compiled with libEigen alignment disabled, although it should be possible to enable in on modern compilers (see https://github.com/alicevision/CCTag/blob/develop/src/CMakeLists.txt#L250). When libEigen alignment are disabled incctag
, reverse dependencies that link tocctag
also need to disable libEigen alignments in order to ensure binary compatibility.Steps To Reproduce
Steps to reproduce the behavior:
cctag
$dev/lib/cmake/CCTag/CCTagTargets.cmake
EIGEN_MAX_ALIGN_BYTES=0;EIGEN_MAX_STATIC_ALIGN_BYTES=0
Expected behavior
cctag
does not export definitions that disable libEigen alignments (e.g.EIGEN_MAX_ALIGN_BYTES=0;EIGEN_MAX_STATIC_ALIGN_BYTES=0
)Additional context
With this being fixed, AliceVision could be compiled with libEigen alignments and
cctag
support here: #256115Notify maintainers
@hesiod
Metadata
The text was updated successfully, but these errors were encountered: