Build failure: webcord on nixos-23.05

[lelgenio]

Steps To Reproduce

Steps to reproduce the behavior:

1. build webcord on nixos-23.05

Build log

 Known issues:
  - Electron version 24.8.6 is EOL

 You can install it anyway by allowing this package, using the
 following methods:

 a) To temporarily allow all insecure packages, you can use an environment
    variable for a single invocation of the nix tools:

      $ export NIXPKGS_ALLOW_INSECURE=1

  Note: For `nix shell`, `nix build`, `nix develop` or any other Nix 2.4+
  (Flake) command, `--impure` must be passed in order to read this
  environment variable.

 b) for `nixos-rebuild` you can add ‘electron-24.8.6’ to
    `nixpkgs.config.permittedInsecurePackages` in the configuration.nix,
    like so:

      {
        nixpkgs.config.permittedInsecurePackages = [
          "electron-24.8.6"
        ];
      }

 c) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
    ‘electron-24.8.6’ to `permittedInsecurePackages` in
    ~/.config/nixpkgs/config.nix, like so:

      {
        permittedInsecurePackages = [
          "electron-24.8.6"
        ];
      }
(use '--show-trace' to show detailed location information)

Additional context

It seems to work if you update to electron 25

pkgs.webcord.override {
  electron_24 = pkgs.electron_25;
}

Notify maintainers

@huantianad

Metadata

Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.

 - system: `"x86_64-linux"`
 - host os: `Linux 6.1.59, NixOS, 23.05 (Stoat), 23.05.20231106.41de143`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.13.6`
 - nixpkgs: `/nix/store/s02jdlqmv902b0y19jy4kybl86ylwvvy-source`

[MikaelFangel]

What is the output when you run export NIXPKGS_ALLOW_INSECURE=1 before building the package? Because this does not look like a build failure. It most of all looks like the result of the package was marked vulnerable not long ago.

Or in general depending on how you build it configure it in one of the ways listed in the build log.

[lelgenio]

Yeah, it still works if you allow insecure packages.

Sorry for causing confusion by marking it as a build failure, it's the closest thing I could think of for "if you try to install it, it won't work".

23.11 is not out yet, so I suppose it's still worth it to fix this, should we just update electron or backport the updates from master?

[huantianad]

What was the reason that we're using electron 24 right now? Was it that 25+ caused crashes on vencord? Perhaps that's been fixed by now.

Going to bring in @FlafyDev @NotAShelf @eclairevoyant

[NotAShelf]

We've went back and forth with the electron version a while back. I cannot remember the exact reason, but I'm sure there was a good one.

[MikaelFangel]

Ref #263231

[huantianad]

Should we wait for that PR to be merged, or should we backport webcord changes up to ed6a8b5?

[MikaelFangel]

I would guess that the PR will not get merge. It's just for future reference and documentation because of their relation (:

[eclairevoyant]

@huantianad I only know of electron 26 causing issues in the past (SpacingBat3/WebCord#452) but not aware of any issues with 25

[huantianad]

With the deprecation of 23.05, should we close this issue?

[lelgenio]

Now that 23.11 is out, I'm not sure anyone really cares about this. If someone really wants to use webcord on 23.05, it's trivial to update electron.