Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.05] Build failure: ffmpeg_7-full #335351

Closed
Eveeifyeve opened this issue Aug 17, 2024 · 9 comments
Closed

[24.05] Build failure: ffmpeg_7-full #335351

Eveeifyeve opened this issue Aug 17, 2024 · 9 comments
Labels
0.kind: build failure A package fails to build 6.topic: darwin Running or building packages on Darwin

Comments

@Eveeifyeve
Copy link
Contributor

Steps To Reproduce

Steps to reproduce the behavior:

  1. build ffmpeg_7-full on aarch64-darwin.

Build log

CC      tests/checkasm/v210dec.o
1 warning generated.
CC      tests/checkasm/v210enc.o
CC      tests/checkasm/vc1dsp.o
CC      tests/checkasm/vf_blend.o
CC      tests/checkasm/vf_bwdif.o
CC      tests/checkasm/vf_colorspace.o
CC      tests/checkasm/vf_convolution.o
CC      tests/checkasm/vf_eq.o
18 warnings generated.
CC      tests/checkasm/vf_gblur.o
CC      tests/checkasm/vf_hflip.o
CC      tests/checkasm/vf_nlmeans.o
CC      tests/checkasm/vf_threshold.o
CC      tests/checkasm/videodsp.o
CC      tests/checkasm/vorbisdsp.o
CC      tests/checkasm/vp8dsp.o
CC      tests/checkasm/vp9dsp.o
CC      tests/checkasm/vvc_mc.o
AR      libavdevice/libavdevice.a
AR      libpostproc/libpostproc.a
CC      tests/api/api-threadmessage-test.o
CC      tests/api/api-flac-test.o
CC      tests/api/api-seek-test.o
HOSTCC  tests/audiogen.o
HOSTCC  tests/videogen.o
COPY    tests/data/filtergraphs/anequalizer
COPY    tests/data/filtergraphs/firequalizer
COPY    tests/data/filtergraphs/compand
COPY    tests/data/filtergraphs/channelmap_one_int
GEN     tests/data/hls-list.m3u8
GEN     tests/data/hls-list-append.m3u8
COPY    tests/data/filtergraphs/channelmap_one_str
COPY    tests/data/filtergraphs/overlay
COPY    tests/data/filtergraphs/overlay_rgb
make: *** [tests/fate/filter-audio.mak:209: tests/data/hls-list.m3u8] Error 134
make: *** Waiting for unfinished jobs....
make: *** [tests/fate/filter-audio.mak:219: tests/data/hls-list-append.m3u8] Error 134

Additional context

This is an issue something to with ffmpeg internals with nix on aarch64-darwin.

Notify maintainers

@Atemu, @arthsmn @jopejoe1

Metadata

warning: ignoring untrusted substituter 'https://nix-community.cachix.org', you are not a trusted user.
Run `man nix.conf` for more information on the `substituters` configuration option.
 - system: `"aarch64-darwin"`
 - host os: `Darwin 24.0.0, macOS 15.0`
 - multi-user?: `yes`
 - sandbox: `no`
 - version: `nix-env (Nix) 2.23.3`
 - channels(root): `"nixpkgs"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixpkgs`

Add a 👍 reaction to issues you find important.

@Eveeifyeve Eveeifyeve added the 0.kind: build failure A package fails to build label Aug 17, 2024
@Eveeifyeve Eveeifyeve changed the title Build failure: ffmpeg Build failure: ffmpeg_7-full Aug 17, 2024
@jopejoe1
Copy link
Member

jopejoe1 commented Aug 17, 2024

This was fixed on unstable by the following prs #322724 #328424 #329380 #328420, but this was not backported to 24.05.

@eclairevoyant eclairevoyant added the 6.topic: darwin Running or building packages on Darwin label Aug 17, 2024
@Atemu Atemu changed the title Build failure: ffmpeg_7-full [24.05] Build failure: ffmpeg_7-full Aug 17, 2024
@Eveeifyeve
Copy link
Contributor Author

I have updated my channel trying to build the package again.

@Eveeifyeve
Copy link
Contributor Author

But I am on unstable anyways so this shouldn't be a problem.

@Eveeifyeve
Copy link
Contributor Author

Eveeifyeve commented Aug 18, 2024

I just had to update my channel and that seemed to fix the issue.
For flake update using nix flake update and non-flakes use nix-channel --update.

@Atemu
Copy link
Member

Atemu commented Aug 18, 2024

I also just checked nixos-24.05 just to be sure and ffmpeg_7-full builds just fine.

@jopejoe1
Copy link
Member

I also just checked nixos-24.05 just to be sure and ffmpeg_7-full builds just fine.

Strange i was checking hydra and the build for ffmpeg_7-full on darwin-24.05 was failing.

https://hydra.nixos.org/job/nixpkgs/nixpkgs-24.05-darwin/ffmpeg_7-full.aarch64-darwin

@Atemu
Copy link
Member

Atemu commented Aug 18, 2024

Ohhh, darwin. Right.

Not sure whether we want to bother backporting that. I don't think it's worth it personally.

@Atemu Atemu reopened this Aug 18, 2024
@Eveeifyeve
Copy link
Contributor Author

Eveeifyeve commented Aug 24, 2024

Ohhh, darwin. Right.

Not sure whether we want to bother backporting that. I don't think it's worth it personally.

It's failing at make: *** [tests/fate/filter-audio.mak:209: tests/data/hls-list.m3u8] Error 134 for aarch64-darwin.

x86_64 stripped errors:

libavdevice/avfoundation.m:765:41: error: must use 'enum' tag to refer to type 'AVMediaType'
static NSArray* getDevicesWithMediaType(AVMediaType mediaType) {
                                        ^
                                        enum 
libavdevice/avfoundation.m:816:50: error: incompatible integer to pointer conversion sending 'enum AVMediaType' to parameter of type 'NSString *' [-Wint-conversion]
    return [AVCaptureDevice devicesWithMediaType:mediaType];
                                                 ^~~~~~~~~
libavdevice/avfoundation.m:829:54: error: incompatible pointer to integer conversion passing 'NSString *const' to parameter of type 'enum AVMediaType' [-Wint-conversion]
    NSArray *devices       = getDevicesWithMediaType(AVMediaTypeVideo);
                                                     ^~~~~~~~~~~~~~~~
libavdevice/avfoundation.m:830:54: error: incompatible pointer to integer conversion passing 'NSString *const' to parameter of type 'enum AVMediaType' [-Wint-conversion]
    NSArray *devices_muxed = getDevicesWithMediaType(AVMediaTypeMuxed);
                                                     ^~~~~~~~~~~~~~~~
libavdevice/avfoundation.m:865:43: error: incompatible pointer to integer conversion passing 'NSString *const' to parameter of type 'enum AVMediaType' [-Wint-conversion]
        devices = getDevicesWithMediaType(AVMediaTypeAudio);
                                          ^~~~~~~~~~~~~~~~
libavdevice/avfoundation.m:989:52: error: incompatible pointer to integer conversion passing 'NSString *const' to parameter of type 'enum AVMediaType' [-Wint-conversion]
        NSArray *devices = getDevicesWithMediaType(AVMediaTypeAudio);
                                                   ^~~~~~~~~~~~~~~~
libavdevice/avfoundation.m:1002:52: error: incompatible pointer to integer conversion passing 'NSString *const' to parameter of type 'enum AVMediaType' [-Wint-conversion]
        NSArray *devices = getDevicesWithMediaType(AVMediaTypeAudio);
                                                   ^~~~~~~~~~~~~~~~

make: *** [ffbuild/common.mak:87: libavdevice/avfoundation.o] Error 1

Hydra Links:

hope that helps @Atemu.

@Atemu
Copy link
Member

Atemu commented Aug 24, 2024

We know the cause (it's already fixed on unstable), we're just deliberating whether we should bother to backport because it was broken on 24.05 from the beginning.

Given @jopejoe1 appears to have the same opinion as me, I don't think we will.

@Atemu Atemu closed this as not planned Won't fix, can't repro, duplicate, stale Aug 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: build failure A package fails to build 6.topic: darwin Running or building packages on Darwin
Projects
None yet
Development

No branches or pull requests

4 participants