Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake is outdated #55060

Closed
lilyball opened this issue Feb 1, 2019 · 4 comments
Closed

cmake is outdated #55060

lilyball opened this issue Feb 1, 2019 · 4 comments
Labels
9.needs: package (update) This needs a package to be updated

Comments

@lilyball
Copy link
Member

lilyball commented Feb 1, 2019

Issue description

The current version of cmake in nixpkgs is 3.12.1 (and there's a PR to bump this to 3.12.2 - #54836) but the current version of CMake is 3.13.3. In fact, CMake 3.13.0 came out over 2 months ago. I skimmed the 3.13.0 release notes and nothing jumps out at me as being backwards-incompatible (though I barely know CMake so I could be missing something).

CC @ttuegel @LnL7

@veprbl veprbl added the 9.needs: package (update) This needs a package to be updated label Feb 2, 2019
@dtzWill
Copy link
Member

dtzWill commented Feb 2, 2019

I had the same thought when I noticed the PR bumping to 3.12.2 haha. Don't know the reason though, sorry :).

@luzpaz
Copy link
Contributor

luzpaz commented Feb 2, 2019

3.13.4 is actually the current version
https://cmake.org/cmake/help/v3.13/release/3.13.html#id19

@stites
Copy link
Member

stites commented Feb 11, 2019

I don't mind bumping #54836 to 3.13.4. I'm primarily interested in fixing my libtorch build on nixos, but I can't yet confirm that everything builds correctly on 3.13 (in fact I'm getting the same error as referenced before when moving back to Ubuntu with an updated cmake). I'm doing some rebuilds this week and I'll doublecheck bumping to the latest current cmake (since I have everything set up already).

Obviously, it makes sense to bump to 3.13.4 in nixpkgs since it's the most current stable release. I got sidetracked on my own problems, apologies!

This was referenced Feb 19, 2019
@stites
Copy link
Member

stites commented Feb 22, 2019

3.13.4 is now in staging! I think this means we can close this issue.

@vcunat vcunat closed this as completed Feb 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
9.needs: package (update) This needs a package to be updated
Projects
None yet
Development

No branches or pull requests

6 participants