Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test GDM in gnome3-xorg test #66443

Closed
worldofpeace opened this issue Aug 10, 2019 · 2 comments
Closed

Test GDM in gnome3-xorg test #66443

worldofpeace opened this issue Aug 10, 2019 · 2 comments
Labels
0.kind: bug Something is broken 0.kind: enhancement Add something new 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: testing Tooling for automated testing of packages and modules

Comments

@worldofpeace
Copy link
Contributor

Describe the bug

Currently with the following diff

diff --git a/nixos/tests/gnome3-xorg.nix b/nixos/tests/gnome3-xorg.nix
index f12361da037..bfc76c39345 100644
--- a/nixos/tests/gnome3-xorg.nix
+++ b/nixos/tests/gnome3-xorg.nix
@@ -11,13 +11,18 @@ import ./make-test.nix ({ pkgs, ...} : {
 
       services.xserver.enable = true;
 
-      services.xserver.displayManager.gdm.enable = false;
-      services.xserver.displayManager.lightdm.enable = true;
-      services.xserver.displayManager.lightdm.autoLogin.enable = true;
-      services.xserver.displayManager.lightdm.autoLogin.user = "alice";
       services.xserver.desktopManager.gnome3.enable = true;
       services.xserver.desktopManager.default = "gnome-xorg";
 
+      services.xserver.displayManager.gdm = {
+        wayland = false;
+        enable = true;
+        autoLogin = {
+          enable = true;
+          user = "alice";
+        };
+      };
+
       virtualisation.memorySize = 1024;
     };
 

it stalls with this repeating message in the output

machine: must succeed: xwininfo -root -tree | sed 's/.*0x[0-9a-f]* \"\([^\"]*\)\".*/\1/; t; d'
machine# No protocol specified
machine# xwininfo: error: unable to open display ":0.0"
machine: exit status 0
(0.04 seconds)
machine: must succeed: xwininfo -root -tree | sed 's/.*0x[0-9a-f]* \"\([^\"]*\)\".*/\1/; t; d'
machine# No protocol specified
machine# xwininfo: error: unable to open display ":0.0"
machine: exit status 0
(0.03 seconds)

cc @jtojnar

@worldofpeace worldofpeace added 0.kind: bug Something is broken 0.kind: enhancement Add something new 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: testing Tooling for automated testing of packages and modules labels Aug 10, 2019
@worldofpeace
Copy link
Contributor Author

I could add something like

setXSession = session: "${gdbus} call --system -d org.freedesktop.Accounts -o /org/freedesktop/Accounts/User1000 -m org.freedesktop.Accounts.User.SetXSession ${session}";

services.xserver.displayManager.job.preStart = setXSession "gnome-flashback-${wmName}";

for the flashback tests and probably rewrite the gnome3-xorg one. But I'm not sure if it's worth it just yet if there's development happening on the python testing driver.
(this would be some functionality I'd want within it...)

@worldofpeace
Copy link
Contributor Author

Yay, we rewrote the test and with the help of https://github.com/NixOS/nixpkgs/blob/master/nixos/modules/services/x11/display-managers/set-session.py allows us to force the session to gnome-xorg.

@JohnRTitor JohnRTitor added this to GNOME Jun 20, 2024
@JohnRTitor JohnRTitor moved this to Done in GNOME Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: bug Something is broken 0.kind: enhancement Add something new 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: testing Tooling for automated testing of packages and modules
Projects
Status: Done
Development

No branches or pull requests

1 participant