-
-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "linter" warning for common unstable fetchpatch URLs #72294
Comments
Thank you for your contributions.
|
still important to me |
I marked this as stale due to inactivity. → More info |
still important to me |
Important to me as well. |
Perhaps this issue could be “moved” to nixpkgs-hammering? I believe that is the tool that @r-rmcgibbo runs to get suggestions for PRs? Also the debian-sources check mentioned on jtojnar/nixpkgs-hammering#1 looks kind of similar to this issue. |
I marked this as stale due to inactivity. → More info |
Doing
git grep -E 'url = .*archlinux.*.patch' | grep -v 'id='
shows that many packages use unstable URLs infetchpatch
whose contents will change as the upstream changes their patches, and break builds and reproducibility then.Example from current nixpkgs
master
:It would be cool to have some form of regex-list based warning shown to the user and in PRs that detects e.g. use of common locations like
archlinux.org
and probably Gentoo and Alpine, when they are used infetchpatch
URLs with.The text was updated successfully, but these errors were encountered: