Skip to content

aws-sam-cli: avoid hard-coded requests version (use the nix package version) #67286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
scoates wants to merge 1 commit into from
Closed

aws-sam-cli: avoid hard-coded requests version (use the nix package version) #67286

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkgs/development/tools/aws-sam-cli/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ buildPythonApplication rec {
];

postPatch = ''
substituteInPlace requirements/base.txt --replace "requests==2.20.1" "requests==2.22.0"
substituteInPlace requirements/base.txt --replace "requests==2.20.1" "requests==${requests.version}"
Copy link
Contributor

@jonringer jonringer Aug 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our version should always be the latest, i say we should just use the compatible operator, and be done with it. (It's the same as saying requests>=2.2,2.*. So it will break if requests ever releases a major bump, but should work otherwise. This should prevent us from needing to touch this ever again)

Suggested change
substituteInPlace requirements/base.txt --replace "requests==2.20.1" "requests==${requests.version}"
sed -i '/requests==2/c\requests~=2.2' requirements/base.txt

substituteInPlace requirements/base.txt --replace "six~=1.11.0" "six~=1.12.0"
substituteInPlace requirements/base.txt --replace "PyYAML~=3.12" "PyYAML~=5.1"
'';
Expand Down