You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When I submit a PR for a bundlerApp package where all I did was modify the Gemfile.lock and gemset.nix files, ofborg doesn't detect the package and therefore doesn't label my PR correctly (e.g. it's missing 8.has: package (update) and 11.by: package-maintainer).
I'm not actually sure what logic ofborg uses to detect the packages modified by the PR, so I don't know what the best approach for teaching it about this scenario. One simple possibility would be if the PR title or any commit in the PR follows the format "attrname: …" then check that attribute and see if anything in it was modified by the PR. That simple check would handle the above PR, because the cocoapods-beta attribute is a derivation that references both Gemfile.lock and gemset.nix (and in fact its version attribute is also changed since that comes from gemset.nix).
The text was updated successfully, but these errors were encountered:
If ofborg can also use the commit titles, then I don't think we need to complicate the part that detects based on files. In that case it is related to #318.
E.g., foobar: 50 -> 60 is simply an upgrade for which we have a label, and foobar: init at 50 is a new package. Maybe we only need to check whether it is in the nixos/ folder or not.
When I submit a PR for a
bundlerApp
package where all I did was modify theGemfile.lock
andgemset.nix
files, ofborg doesn't detect the package and therefore doesn't label my PR correctly (e.g. it's missing8.has: package (update)
and11.by: package-maintainer
).Example PR: NixOS/nixpkgs#66251
I'm not actually sure what logic ofborg uses to detect the packages modified by the PR, so I don't know what the best approach for teaching it about this scenario. One simple possibility would be if the PR title or any commit in the PR follows the format "attrname: …" then check that attribute and see if anything in it was modified by the PR. That simple check would handle the above PR, because the
cocoapods-beta
attribute is a derivation that references bothGemfile.lock
andgemset.nix
(and in fact itsversion
attribute is also changed since that comes fromgemset.nix
).The text was updated successfully, but these errors were encountered: