Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template paths need to be nix store paths #65

Open
aaronmondal opened this issue Apr 10, 2023 · 0 comments
Open

Template paths need to be nix store paths #65

aaronmondal opened this issue Apr 10, 2023 · 0 comments

Comments

@aaronmondal
Copy link

According to the flake output schema docs the template path argument needs to be a nix store path. CI using something like

nix --store ~/nix flake check -L

would currently fail because the paths are relative. This is not noticeable without the --store flag on an empty nix store, because the paths in local git repos will already be on the users local /nix/store path. I think the solution here is to convert all template directories to implicit derivations by using something like this:

- path = ./mytemplate;
+ path = "${./mytemplate}";

@domenkozar I think this is is also an issue in the devenv repo and probably in many other repos as well. We noticed this because our CI for eomii/rules_ll#65 failed. Before I start sending PRs everywhere, is my proposed solution correct or am I missing something?

cc @jaroeichler

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant