Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] Make the Y_df argument of HierarchicalForecast.reconcile optional #59

Closed
AzulGarza opened this issue Sep 29, 2022 · 0 comments · Fixed by #65
Closed

[FEAT] Make the Y_df argument of HierarchicalForecast.reconcile optional #59

AzulGarza opened this issue Sep 29, 2022 · 0 comments · Fixed by #65

Comments

@AzulGarza
Copy link
Member

Some methods don't use the in-sample values of the time series (for example BottomUp, MinTrace(method='ols'), TopDown(method='forecast_proportions')). Therefore, the Y_df argument should be optional to avoid overcomplexity using the reconcile method and should be requested only when necessary.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[FIX] Make Y_df optional for the reconcile method Nixtla/hierarchicalforecast
1 participant
@AzulGarza