Skip to content

breaking: remove window_ops and numba dependencies #462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Dec 6, 2024
Merged

Conversation

jmoralez
Copy link
Member

@jmoralez jmoralez commented Dec 5, 2024

Description

Removes the dependency on window-ops and numba to achieve the following:

  • Having less dependencies and thus reduce deployment sizes (llvmlite is ~130MB uncompressed).
  • Being less dependent on numba supporting python versions, e.g. removing numba right now allows us to support python 3.13.
  • Lean users towards using the built-in transformations, which are faster and allow us to have more information, e.g. feat: infer samples required for built-in lag transforms updates #445

Also removes the lag_transforms extra, since that was introduced during the transition from numba to coreforecast and has been empty for a while.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

codspeed-hq bot commented Dec 5, 2024

CodSpeed Performance Report

Merging #462 will not alter performance

Comparing remove-numba-dep (6901257) with main (6b60a4d)

Summary

✅ 12 untouched benchmarks

@jmoralez jmoralez marked this pull request as ready for review December 6, 2024 18:03
@jmoralez jmoralez merged commit da8d9e2 into main Dec 6, 2024
26 checks passed
@jmoralez jmoralez deleted the remove-numba-dep branch December 6, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant