Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic update check does not work at start #25

Closed
DrUm78 opened this issue Apr 25, 2019 · 4 comments
Closed

Automatic update check does not work at start #25

DrUm78 opened this issue Apr 25, 2019 · 4 comments

Comments

@DrUm78
Copy link

DrUm78 commented Apr 25, 2019

Hello and thanks for this new 1.3.0 release, I'm still using your app on my pc. :)

One little bug though: the automatic update check at launch does not work and does not say that a new version is out. I noticed 1.3.0 version by coming on this page after a few months.

To get the update notification to appear, you have to uncheck the option (right click and 'Check new version on start') then check it again.

Keep up the good work!

@NiyaShy
Copy link
Owner

NiyaShy commented Apr 25, 2019

Hey,

I feared this was the case, just never had the time to try it out for confirmation. So thanks for letting me know, I'll look into it.

@NiyaShy NiyaShy added the bug label Apr 25, 2019
@NiyaShy NiyaShy added this to the v1.3.1 milestone Apr 25, 2019
@NiyaShy
Copy link
Owner

NiyaShy commented May 1, 2019

Found the cause. As stupid as it sounds, it was forgotten to actually call the "check for updates" routine on startup, so it was only called when you check the option.
Will get fixed with the next version.

@DrUm78
Copy link
Author

DrUm78 commented May 1, 2019

Great, thanks. :)

@NiyaShy NiyaShy added the Implemented/fixed in testing Feature/fix is already in the testing code but not yet released as a new version label May 2, 2019
@NiyaShy NiyaShy added Implemented/fixed and released and removed Implemented/fixed in testing Feature/fix is already in the testing code but not yet released as a new version labels Jun 18, 2019
@NiyaShy
Copy link
Owner

NiyaShy commented Jun 18, 2019

Just uploaded the new version that includes the fix. So from now on update check should work as intended ;)

@NiyaShy NiyaShy closed this as completed Jun 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants