Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Globalize Product ID #522

Open
1 of 8 tasks
zccz14 opened this issue Apr 23, 2024 · 3 comments
Open
1 of 8 tasks

feat: Globalize Product ID #522

zccz14 opened this issue Apr 23, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@zccz14
Copy link
Contributor

zccz14 commented Apr 23, 2024

Describe the feature

Make all product ID unique for global.

Embed datasource_id into product_id field.

  • feat: General Tree Data Record #707
  • Remove datasource_id in Product
  • Remove datasource_id in Period
  • Remove datasource_id in PSR
  • Remove datasource_id in GSR
  • Remove datasource_id in AccountInfo's positions
  • Remove datasource_id in FundingRate
  • Remove datasource_id in Tick

Why do you need this feature?

  • We can view all products in a tree view
  • Easily compose accounts
  • Remove the 'datasource' concept (make it simpler)
  • Position can link to a certain product

Additional context

No response

@zccz14 zccz14 added the enhancement New feature or request label Apr 23, 2024
@zccz14
Copy link
Contributor Author

zccz14 commented Jul 18, 2024

#715

@zccz14
Copy link
Contributor Author

zccz14 commented Aug 12, 2024

Some additional points. Using a tree-structured resource management model involves more than just concatenating datasource_id and product_id together. For instance:

  1. Replace the previous calls to encodePath, decodePath with standard posix-style path libraries (in browser environments, these libraries can be used by configuring the packager, and the same consideration should be given when packaging plugins as IIFE).
  2. Consider alternative methods for provideTicks.
  3. Consider alternatives for decodePath within provideDataSeries.
  4. After simplifying GSR into two fields, should it be directly merged into the IProduct interface? Or has it become meaningless altogether?

@zccz14
Copy link
Contributor Author

zccz14 commented Aug 12, 2024

We will never again seek to impose any requirements on the path format of product_id.
We will never demand to extract any structured information from the hierarchical path of product_id.
Therefore, the specific structure within the product_id path is no longer important; what matters is:

  1. Establishing jurisdiction. Each vendor is responsible for offering a portion of the products.
  2. Determining hierarchical and kinship relationships for certain classification statistics and data consumption.
  3. To accommodate the limited capacity of the human brain, allowing for the management of the vast amount of diverse product information by breaking it down.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant