Skip to content

Commit 7c64c33

Browse files
Nurhan TurgutNoamDev
Nurhan Turgut
authored and
NoamDev
committed
[web] Running safari tests on LUCI (flutter#16715)
* Safari font collection tests skip failing methods * add a clear to the semantics test to make sure no DOM elements are leaking to the other tests * fix semantics_helper_test. skip for semantics_test. teardown didn't work * skip test, the skipped method run for 8 minutes according to the logs * history tests methods runs multiple times. only run them on linux for now. they were also already failing in edge/windows
1 parent e9fe7c1 commit 7c64c33

File tree

4 files changed

+41
-15
lines changed

4 files changed

+41
-15
lines changed

‎lib/web_ui/test/engine/history_test.dart‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@
33
// found in the LICENSE file.
44

55
// @dart = 2.6
6+
@TestOn('vm && linux')
7+
68
import 'dart:async';
79
import 'dart:typed_data';
810

@@ -158,7 +160,8 @@ void main() {
158160
expect(strategy.currentEntryIndex, -1);
159161
},
160162
// TODO(nurhan): https://github.com/flutter/flutter/issues/50836
161-
skip: browserEngine == BrowserEngine.edge);
163+
skip: browserEngine == BrowserEngine.edge ||
164+
browserEngine == BrowserEngine.webkit);
162165

163166
test('handle user-provided url', () async {
164167
strategy =

‎lib/web_ui/test/engine/semantics/semantics_helper_test.dart‎

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -59,11 +59,14 @@ void main() {
5959

6060
expect(shouldForwardToFramework, true);
6161

62-
event = html.PointerEvent('pointermove');
63-
shouldForwardToFramework =
64-
desktopSemanticsEnabler.tryEnableSemantics(event);
62+
// Pointer events are not defined in webkit.
63+
if (browserEngine != BrowserEngine.webkit) {
64+
event = html.PointerEvent('pointermove');
65+
shouldForwardToFramework =
66+
desktopSemanticsEnabler.tryEnableSemantics(event);
6567

66-
expect(shouldForwardToFramework, true);
68+
expect(shouldForwardToFramework, true);
69+
}
6770
},
6871
// TODO(nurhan): https://github.com/flutter/flutter/issues/50754
6972
skip: browserEngine == BrowserEngine.edge);

‎lib/web_ui/test/engine/semantics/semantics_test.dart‎

Lines changed: 15 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -396,8 +396,10 @@ void _testVerticalScrolling() {
396396

397397
semantics().semanticsEnabled = false;
398398
},
399+
// TODO(nurhan): https://github.com/flutter/flutter/issues/50590
399400
// TODO(nurhan): https://github.com/flutter/flutter/issues/50754
400-
skip: browserEngine == BrowserEngine.edge);
401+
skip: browserEngine == BrowserEngine.webkit ||
402+
browserEngine == BrowserEngine.edge);
401403

402404
test('scrollable node with children has a container node', () async {
403405
semantics()
@@ -432,8 +434,10 @@ void _testVerticalScrolling() {
432434

433435
semantics().semanticsEnabled = false;
434436
},
437+
// TODO(nurhan): https://github.com/flutter/flutter/issues/50590
435438
// TODO(nurhan): https://github.com/flutter/flutter/issues/50754
436-
skip: browserEngine == BrowserEngine.edge);
439+
skip: browserEngine == BrowserEngine.webkit ||
440+
browserEngine == BrowserEngine.edge);
437441

438442
test('scrollable node dispatches scroll events', () async {
439443
final StreamController<int> idLogController = StreamController<int>();
@@ -544,8 +548,10 @@ void _testHorizontalScrolling() {
544548

545549
semantics().semanticsEnabled = false;
546550
},
551+
// TODO(nurhan): https://github.com/flutter/flutter/issues/50590
547552
// TODO(nurhan): https://github.com/flutter/flutter/issues/50754
548-
skip: browserEngine == BrowserEngine.edge);
553+
skip: browserEngine == BrowserEngine.webkit ||
554+
browserEngine == BrowserEngine.edge);
549555

550556
test('scrollable node with children has a container node', () async {
551557
semantics()
@@ -580,8 +586,10 @@ void _testHorizontalScrolling() {
580586

581587
semantics().semanticsEnabled = false;
582588
},
589+
// TODO(nurhan): https://github.com/flutter/flutter/issues/50590
583590
// TODO(nurhan): https://github.com/flutter/flutter/issues/50754
584-
skip: browserEngine == BrowserEngine.edge);
591+
skip: browserEngine == BrowserEngine.webkit ||
592+
browserEngine == BrowserEngine.edge);
585593

586594
test('scrollable node dispatches scroll events', () async {
587595
final SemanticsActionLogger logger = SemanticsActionLogger();
@@ -1140,8 +1148,10 @@ void _testTappable() {
11401148

11411149
semantics().semanticsEnabled = false;
11421150
},
1151+
// TODO(nurhan): https://github.com/flutter/flutter/issues/50590
11431152
// TODO(nurhan): https://github.com/flutter/flutter/issues/50754
1144-
skip: browserEngine == BrowserEngine.edge);
1153+
skip: browserEngine == BrowserEngine.webkit ||
1154+
browserEngine == BrowserEngine.edge);
11451155
}
11461156

11471157
void _testImage() {

‎lib/web_ui/test/text/font_collection_test.dart‎

Lines changed: 15 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,9 @@ void main() {
5757
expect(fontFamilyList.first, 'Ahem ahem ahem');
5858
},
5959
// TODO(nurhan): https://github.com/flutter/flutter/issues/50770
60-
skip: browserEngine == BrowserEngine.edge);
60+
// TODO(nurhan): https://github.com/flutter/flutter/issues/51142
61+
skip: browserEngine == BrowserEngine.edge ||
62+
browserEngine == BrowserEngine.webkit);
6163

6264
test('Register Asset with capital case letters', () async {
6365
final String _testFontFamily = "AhEm";
@@ -101,7 +103,9 @@ void main() {
101103
}
102104
},
103105
// TODO(nurhan): https://github.com/flutter/flutter/issues/50770
104-
skip: browserEngine == BrowserEngine.edge);
106+
// TODO(nurhan): https://github.com/flutter/flutter/issues/51142
107+
skip: browserEngine == BrowserEngine.edge ||
108+
browserEngine == BrowserEngine.webkit);
105109

106110
test('Register Asset twice with exclamation mark', () async {
107111
final String _testFontFamily = 'Ahem!!ahem';
@@ -125,7 +129,9 @@ void main() {
125129
}
126130
},
127131
// TODO(nurhan): https://github.com/flutter/flutter/issues/50770
128-
skip: browserEngine == BrowserEngine.edge);
132+
// TODO(nurhan): https://github.com/flutter/flutter/issues/51142
133+
skip: browserEngine == BrowserEngine.edge ||
134+
browserEngine == BrowserEngine.webkit);
129135

130136
test('Register Asset twice with comma', () async {
131137
final String _testFontFamily = 'Ahem ,ahem';
@@ -149,7 +155,9 @@ void main() {
149155
}
150156
},
151157
// TODO(nurhan): https://github.com/flutter/flutter/issues/50770
152-
skip: browserEngine == BrowserEngine.edge);
158+
// TODO(nurhan): https://github.com/flutter/flutter/issues/51142
159+
skip: browserEngine == BrowserEngine.edge ||
160+
browserEngine == BrowserEngine.webkit);
153161

154162
test('Register Asset twice with a digit at the start of a token',
155163
() async {
@@ -174,7 +182,9 @@ void main() {
174182
}
175183
},
176184
// TODO(nurhan): https://github.com/flutter/flutter/issues/50770
177-
skip: browserEngine == BrowserEngine.edge);
185+
// TODO(nurhan): https://github.com/flutter/flutter/issues/51142
186+
skip: browserEngine == BrowserEngine.edge ||
187+
browserEngine == BrowserEngine.webkit);
178188
});
179189
});
180190
}

0 commit comments

Comments
 (0)