Skip to content

Commit a448674

Browse files
authored
Revert "Suppress some deprecation warnings on Windows (flutter#16416)"
This reverts commit 230c6b4.
1 parent 9338254 commit a448674

File tree

3 files changed

+0
-20
lines changed

3 files changed

+0
-20
lines changed

fml/BUILD.gn

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -202,11 +202,6 @@ source_set("fml") {
202202
"platform/win/paths_win.cc",
203203
"platform/win/wstring_conversion.h",
204204
]
205-
206-
if (is_win) {
207-
# For wstring_conversion. See issue #50053.
208-
defines = [ "_SILENCE_CXX17_CODECVT_HEADER_DEPRECATION_WARNING" ]
209-
}
210205
} else {
211206
sources += [
212207
"platform/posix/file_posix.cc",

shell/platform/common/cpp/BUILD.gn

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -53,11 +53,6 @@ source_set("common_cpp") {
5353
# won't have a JSON dependency.
5454
defines = [ "USE_RAPID_JSON" ]
5555
deps += [ "//third_party/rapidjson" ]
56-
57-
if (is_win) {
58-
# For wstring_conversion. See issue #50053.
59-
defines += [ "_SILENCE_CXX17_CODECVT_HEADER_DEPRECATION_WARNING" ]
60-
}
6156
}
6257

6358
copy("publish_headers") {

third_party/txt/BUILD.gn

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -28,14 +28,6 @@ config("txt_config") {
2828
include_dirs = [ "src" ]
2929
}
3030

31-
config("allow_posix_names") {
32-
if (is_win && is_clang) {
33-
# POSIX names of many functions are marked deprecated by default;
34-
# disable that since they are used for cross-platform compatibility.
35-
defines = [ "_CRT_NONSTDC_NO_DEPRECATE" ]
36-
}
37-
}
38-
3931
source_set("txt") {
4032
defines = []
4133
if (flutter_use_fontconfig) {
@@ -304,8 +296,6 @@ executable("txt_unittests") {
304296
]
305297
}
306298

307-
configs += [ ":allow_posix_names" ]
308-
309299
deps = [
310300
":txt",
311301
":txt_test_utils",

0 commit comments

Comments
 (0)